Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump DD compat #440

Closed
wants to merge 1 commit into from
Closed

Conversation

asinghvi17
Copy link

Bumps DimensionalData compat in Project.toml to 0.27, 0.28. This should be fine but we'll see from CI.

@lazarusA
Copy link
Collaborator

yeah, it should be fine. I'm also adding a lot of mapCube stuff and setting and upper bound on DiskArrays to 0.3, until the readblock gets fixes. Here. #439

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.51%. Comparing base (59d23fc) to head (590b9a2).
Report is 47 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
+ Coverage   68.30%   68.51%   +0.20%     
==========================================
  Files          12       12              
  Lines        1773     1807      +34     
==========================================
+ Hits         1211     1238      +27     
- Misses        562      569       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Pull Request Test Coverage Report for Build 10935192614

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 67.719%

Totals Coverage Status
Change from base Build 10829126157: -0.8%
Covered Lines: 1223
Relevant Lines: 1806

💛 - Coveralls

@lazarusA
Copy link
Collaborator

it should be completed here #442 I did update other things at the same time.

@lazarusA lazarusA closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants